fix: resolve cross-package test failures and type errors#16
Open
stooit wants to merge 1 commit into
Open
Conversation
- Re-export useDebounce as useSearchDebounce in packages/utils - Export useThrottle from packages/utils and fix import in apps/web - Fix date formatting to omit leading zero on day (d/MM/yyyy) - Add aria-label prop passthrough to Button component for icon-only buttons - Fix stale closure in DataTable sort handler using functional state update - Configure happy-dom preload in root bunfig.toml for UI component tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and type errors across the monorepo. All 13 tests now pass with
bun testandnpx tsc --noEmitreports no source-file type errors.Changes
useDebounceasuseSearchDebounce(hook was renamed but consumers still expected the old name). Also exporteduseThrottle.@e2e/utils.dd/MM/yyyytod/MM/yyyyto omit leading zero on day.aria-labelprop passthrough for accessibility on icon-only buttons.bun testfrom root.Assumptions
bun:testtype errors in test files are expected (would require@types/bunto resolve, which is a new dependency — out of scope).useSearchDebouncealias preserves backward compatibility while keeping the renameduseDebounceas the canonical export.